Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy 0.13 Update #68

Merged
merged 12 commits into from
Feb 23, 2024
Merged

Bevy 0.13 Update #68

merged 12 commits into from
Feb 23, 2024

Conversation

RobWalt
Copy link
Contributor

@RobWalt RobWalt commented Feb 22, 2024 •
edited
Loading

Update: Fixed

Examples are mostly running, please see my comment #68 (comment)!

Irrelevant and superseded by the above now, leaving my intermediate error/debug report for transparency

I did most of the mechanical changes to get the update going. None of the examples are running yet due to a wgpu error related to the shaders. I need to spend some time looking closer at this to fix it tomorrow.

wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
      note: label = `opaque_mesh_pipeline`
    Error matching ShaderStages(FRAGMENT) shader requirements against the pipeline
    Shader global ResourceBinding { group: 1, binding: 0 } is not available in the pipeline layout
    View dimension Cube (is array: false) doesn't match the binding Buffer { ty: Storage { read_only: true }, has_dynamic_offset: false, min_binding_size: Some(160) }

Also, the examples are depending on this PR to be merged: JonahPlusPlus/bevy_spectator#12 This should be updated in the Cargo.toml before this PR is merged.

@RobWalt RobWalt changed the title Bevy 0.13 (Disclaimer: Doesn't work yet!) Bevy 0.13 Update Feb 23, 2024
@RobWalt RobWalt marked this pull request as ready for review February 23, 2024 07:44
@RobWalt
Copy link
Contributor Author

RobWalt commented Feb 23, 2024

Please, whoever reviews this, run the splitscreen example. It doesn't crash for me but it's very glitchy! Not sure if it's related to my setup though.

@Shatur Shatur mentioned this pull request Feb 23, 2024
Closed
@Shatur
Copy link
Collaborator

Shatur commented Feb 23, 2024

Please, whoever reviews this, run the splitscreen example

Runs fine, thanks!

@Shatur Shatur merged commit 0fea12d into JonahPlusPlus:master Feb 23, 2024
4 checks passed
@RobWalt RobWalt deleted the bevy-0.13 branch February 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shatur Shatur Shatur approved these changes

@JonahPlusPlus JonahPlusPlus Awaiting requested review from JonahPlusPlus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobWalt @Shatur